Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tx builder): use cgw for simulation configs #801

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Apr 18, 2024

What it solves

Instead of using a hardcoded list of chains where simulation isn't supported, use CGW/config service to get the config of the current chain and check its features list.

How this PR fixes it

I've replaced a hardcoded array of chain ids with an async call to CGW. I've added useAsync from the wallet repo for this.

Screenshot 2024-04-18 at 11 33 43

@katspaugh katspaugh requested a review from schmanu April 18, 2024 09:09
Instead of using a hardcoded list of chains where simulation isn't supported, use CGW
@katspaugh
Copy link
Member Author

Simulation is disabled on Aurora, so no button is shown:

Screenshot 2024-04-18 at 11 40 36

@katspaugh
Copy link
Member Author

Tested by @liliya-soroka

@katspaugh katspaugh merged commit cbf139e into development Apr 18, 2024
7 of 8 checks passed
@katspaugh katspaugh deleted the txb-cgw branch April 18, 2024 11:13
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant